are JSON changes breaking Jarvis functionality or are they just additional JSON calls? if its additional stuff we can add that in ...Tolriq wrote: 07 Apr 2018, 12:00 So I've added support for MrMC and did more verification.
MrMC JSON level is Jarvis. There's 0 Krypton JSON API changes included.
If DB is at V17 level, then there's quite a few JSON things that would be cool to have for music and the userratings.
Just so I know what to put in the Changelog (Either full support or not) if the fact that it works is a bug that will be fixed.Started to play and it seems Zebra is half working on Android? I can access the sources content without any problems.
Via urls: http://192.168.1.40:8080/vfs/nfs%3A%2F% ... 2Ftoto.mkv
Can only guess https://github.com/MrMC/mrmc/blob/maste ... s.cpp#L257 returns null on Android?
Might worth a check, I love that it does work for my need, but maybe on Android there's still some directory traversal security issues then.
Code: Select all
char *fullpath = realpath(filePath.c_str(), nullptr);
if (fullpath)
{
....
}
else
{
return false;
}
return true;
I think we need to patch that hole, we should not allow any files to be served via webui that are not in userfolderTolriq wrote: 11 Apr 2018, 08:42 ...
Just so I know what to put in the Changelog (Either full support or not) if the fact that it works is a bug that will be fixed.
It was complicated to reach an agreement on Kodi side but I'm sure we can do the same here. Access to sources via a flag that users can configure should be possible.if fullpath is null, end of story... we cant allow it blindlyTolriq wrote: 11 Apr 2018, 11:07 Well no if you do that and it's really null on Android then you lock access to things that should be allowed by Zebra and will probably break things
Fix should probably to have a non null value
...
we have both of those commits in MrMC, it was done in 2013Tolriq wrote: 11 Apr 2018, 11:07 ...
But then the first discussion cames back and I'll ask for support of:
https://github.com/xbmc/xbmc/pull/2764
and
https://github.com/xbmc/xbmc/pull/2828
Or maybe I miss read the Zebra thing but can't test on apple things to confirm
Edit: Please see PR and discussion since start here
You currently doif fullpath is null, end of story... we cant allow it blindly
So maybe I should have not said anything and leave the hole :p Not the kind of guy I'am ) first answer here and reason I added support as I usually do not add things that half works.